Refactor errors, add tests, improve code style #370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpavlov
added
documentation
…ndling and annotations. - Encapsulate exception handling with `toMcpException`. - Move `AbstractTransport` to a separate file. - Add `null` as the default value for optional fields in MCP types. - Rename `McpError` to `McpException` for clarity and better usability. Move to a separate file. Use it in some places instead of IllegalStateException - Gradle: Downgrade `kotest` assertions library to support JDK 8. - Improve `ServerPromptsTest` cases with new scenarios and assertions. - Reformat KDocs and fix Detekt issues - Add additional `@Suppress` annotations to improve readability and control warnings.
kpavlov
force-pushed
the
kpavlov/refactor-errors-and-tests
branch
from
807e4a5 to
953acce
Compare
kpavlov
commented
Nov 5, 2025
| * corresponding [_onClose], [_onError] and [_onMessage] properties to use for an implementation. | ||
| */ | ||
| @Suppress("PropertyName") | ||
| public abstract class AbstractTransport : Transport { |
Contributor
Author
There was a problem hiding this comment.
moved to separate file
Comment on lines
+56
to
+63
| client.getPrompt(GetPromptRequest("test-prompt-with-custom-handler")) shouldBe expectedPromptResult | ||
|
|
||
| client.listPrompts() shouldNotBeNull { | ||
| prompts shouldContainExactly listOf(testPrompt) | ||
| nextCursor shouldBe null | ||
| _meta shouldBe EmptyJsonObject | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
We SHOULD verify that the prompt was actually added
Comment on lines
+126
to
+128
| client.listPrompts() shouldNotBeNull { | ||
| prompts.shouldBeEmpty() | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Actually verify, that prompts were removed
| @Test | ||
| fun `removePrompt should throw when prompts capability is not supported`() = runTest { | ||
| @Nested | ||
| inner class NoPromptsCapabilitiesTests { |
Contributor
Author
There was a problem hiding this comment.
group negative scenarios
| verify { | ||
| rule { | ||
| minBound(65) | ||
| minBound(75) |
tiginamaria
approved these changes
Nov 6, 2025
Contributor
tiginamaria
left a comment
tiginamaria
left a comment
There was a problem hiding this comment.
Looks nice! Thank you
Contributor
Author
|
set to draft to avoid conflicts with @devcrocod's changes |
Contributor
Author
|
Use #376 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor MCP Protocol and related classes for improved exception handling and annotations.
nullas the default value for optional fields in MCP types.McpErrortoMcpExceptionfor clarity and better usability. Move to a separate file. Use it in some places instead of IllegalStateException. CreateMcpExceptionfromJSONRPCErrorwithJSONRPCError.toMcpException()AbstractTransportto a separate file.ServerPromptsTestcases with new scenarios and assertions.kotestassertions library to support JDK 8.@Suppressannotations to improve readability and control warnings.Motivation and Context
Improve ServerPromptsTest;
Provide default values to simplify API usage.
To make use of MCP-specific errors instead of generic
IllegalStateExceptionCleanup code to make issues visible in Detekt.
How Has This Been Tested?
Unit/Integraiton tests, regression tests
Breaking Changes
getPrompt throws new
McpException(exMcpError) instead ofIllegalStateException.Types of changes
Checklist
Additional context